Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameConsole.cpp

Issue 2003433004: Remove dependency from ConsoleMessage to workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1999463002
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 62
63 } 63 }
64 64
65 FrameConsole::FrameConsole(LocalFrame& frame) 65 FrameConsole::FrameConsole(LocalFrame& frame)
66 : m_frame(&frame) 66 : m_frame(&frame)
67 { 67 {
68 } 68 }
69 69
70 void FrameConsole::addMessage(ConsoleMessage* consoleMessage) 70 void FrameConsole::addMessage(ConsoleMessage* consoleMessage)
71 { 71 {
72 if (addMessageToStorage(consoleMessage))
73 reportMessageToClient(consoleMessage);
74 }
75
76 bool FrameConsole::addMessageToStorage(ConsoleMessage* consoleMessage)
77 {
78 if (muteCount && consoleMessage->source() != ConsoleAPIMessageSource)
79 return false;
80 if (!m_frame->document() || !messageStorage())
81 return false;
82 messageStorage()->reportMessage(m_frame->document(), consoleMessage);
83 return true;
84 }
85
86 void FrameConsole::reportMessageToClient(ConsoleMessage* consoleMessage)
87 {
72 if (muteCount && consoleMessage->source() != ConsoleAPIMessageSource) 88 if (muteCount && consoleMessage->source() != ConsoleAPIMessageSource)
73 return; 89 return;
74
75 // FIXME: This should not need to reach for the main-frame.
76 // Inspector code should just take the current frame and know how to walk it self.
77 ExecutionContext* context = frame().document();
78 if (!context)
79 return;
80 if (!messageStorage())
81 return;
82
83 messageStorage()->reportMessage(m_frame->document(), consoleMessage);
84
85 if (consoleMessage->source() == NetworkMessageSource) 90 if (consoleMessage->source() == NetworkMessageSource)
86 return; 91 return;
87
88 if (consoleMessage->source() == ConsoleAPIMessageSource) { 92 if (consoleMessage->source() == ConsoleAPIMessageSource) {
89 if (!frame().host() || (consoleMessage->scriptArguments() && !consoleMes sage->scriptArguments()->argumentCount())) 93 if (!frame().host() || (consoleMessage->scriptArguments() && !consoleMes sage->scriptArguments()->argumentCount()))
90 return; 94 return;
91 if (!allClientReportingMessageTypes().contains(consoleMessage->type())) 95 if (!allClientReportingMessageTypes().contains(consoleMessage->type()))
92 return; 96 return;
93 } 97 }
94 98
95 String stackTrace; 99 String stackTrace;
96 if (consoleMessage->callStack() && frame().chromeClient().shouldReportDetail edMessageForSource(frame(), consoleMessage->url())) 100 if (consoleMessage->callStack() && frame().chromeClient().shouldReportDetail edMessageForSource(frame(), consoleMessage->url()))
97 stackTrace = consoleMessage->callStack()->toString(); 101 stackTrace = consoleMessage->callStack()->toString();
98 frame().chromeClient().addMessageToConsole(m_frame, consoleMessage->source() , consoleMessage->level(), consoleMessage->message(), consoleMessage->lineNumber (), consoleMessage->url(), stackTrace); 102 frame().chromeClient().addMessageToConsole(m_frame, consoleMessage->source() , consoleMessage->level(), consoleMessage->message(), consoleMessage->lineNumber (), consoleMessage->url(), stackTrace);
99 } 103 }
100 104
105 void FrameConsole::reportWorkerMessage(ConsoleMessage* consoleMessage)
106 {
107 reportMessageToClient(consoleMessage);
108 }
109
110 void FrameConsole::adoptWorkerMessage(ConsoleMessage* consoleMessage)
111 {
112 addMessageToStorage(consoleMessage);
113 }
114
101 void FrameConsole::reportResourceResponseReceived(DocumentLoader* loader, unsign ed long requestIdentifier, const ResourceResponse& response) 115 void FrameConsole::reportResourceResponseReceived(DocumentLoader* loader, unsign ed long requestIdentifier, const ResourceResponse& response)
102 { 116 {
103 if (!loader) 117 if (!loader)
104 return; 118 return;
105 if (response.httpStatusCode() < 400) 119 if (response.httpStatusCode() < 400)
106 return; 120 return;
107 if (response.wasFallbackRequiredByServiceWorker()) 121 if (response.wasFallbackRequiredByServiceWorker())
108 return; 122 return;
109 String message = "Failed to load resource: the server responded with a statu s of " + String::number(response.httpStatusCode()) + " (" + response.httpStatusT ext() + ')'; 123 String message = "Failed to load resource: the server responded with a statu s of " + String::number(response.httpStatusCode()) + " (" + response.httpStatusT ext() + ')';
110 ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource , ErrorMessageLevel, message, response.url().getString(), 0, 0); 124 ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource , ErrorMessageLevel, message, response.url().getString(), 0, 0);
(...skipping 19 matching lines...) Expand all
130 return &m_frame->host()->consoleMessageStorage(); 144 return &m_frame->host()->consoleMessageStorage();
131 } 145 }
132 146
133 void FrameConsole::clearMessages() 147 void FrameConsole::clearMessages()
134 { 148 {
135 ConsoleMessageStorage* storage = messageStorage(); 149 ConsoleMessageStorage* storage = messageStorage();
136 if (storage) 150 if (storage)
137 storage->clear(m_frame->document()); 151 storage->clear(m_frame->document());
138 } 152 }
139 153
140 void FrameConsole::adoptWorkerMessagesAfterTermination(WorkerInspectorProxy* pro xy)
141 {
142 ConsoleMessageStorage* storage = messageStorage();
143 if (storage)
144 storage->adoptWorkerMessagesAfterTermination(proxy);
145 }
146
147 void FrameConsole::didFailLoading(unsigned long requestIdentifier, const Resourc eError& error) 154 void FrameConsole::didFailLoading(unsigned long requestIdentifier, const Resourc eError& error)
148 { 155 {
149 if (error.isCancellation()) // Report failures only. 156 if (error.isCancellation()) // Report failures only.
150 return; 157 return;
151 ConsoleMessageStorage* storage = messageStorage(); 158 ConsoleMessageStorage* storage = messageStorage();
152 if (!storage) 159 if (!storage)
153 return; 160 return;
154 StringBuilder message; 161 StringBuilder message;
155 message.appendLiteral("Failed to load resource"); 162 message.appendLiteral("Failed to load resource");
156 if (!error.localizedDescription().isEmpty()) { 163 if (!error.localizedDescription().isEmpty()) {
157 message.appendLiteral(": "); 164 message.appendLiteral(": ");
158 message.append(error.localizedDescription()); 165 message.append(error.localizedDescription());
159 } 166 }
160 ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource , ErrorMessageLevel, message.toString(), error.failingURL(), 0, 0); 167 ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource , ErrorMessageLevel, message.toString(), error.failingURL(), 0, 0);
161 consoleMessage->setRequestIdentifier(requestIdentifier); 168 consoleMessage->setRequestIdentifier(requestIdentifier);
162 storage->reportMessage(m_frame->document(), consoleMessage); 169 storage->reportMessage(m_frame->document(), consoleMessage);
163 } 170 }
164 171
165 DEFINE_TRACE(FrameConsole) 172 DEFINE_TRACE(FrameConsole)
166 { 173 {
167 visitor->trace(m_frame); 174 visitor->trace(m_frame);
168 } 175 }
169 176
170 } // namespace blink 177 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698