Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
200343002:
trivial change to remove the hard coding to mono as the output channel layout in MSAP. (Closed)
|
Created:
6 years, 9 months ago by no longer working on chromium Modified:
6 years, 9 months ago Reviewers:
Henrik Grunell CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org Base URL:
http://git.chromium.org/chromium/src.git@master Visibility:
Public. |
Descriptiontrivial change to remove the hard coding to mono as the output channel layout in the media stream audio processor.
NOTRY=true
BUG=264611
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257367
Patch Set 1 #
Messages
Total messages: 20 (0 generated)
Hi Henrik, a trivial CL, please take a look. Thanks, SX
lgtm
The CQ bit was checked by xians@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/200343002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
The CQ bit was checked by xians@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/200343002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by xians@chromium.org
The CQ bit was unchecked by xians@chromium.org
The CQ bit was checked by xians@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/200343002/1
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by xians@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/200343002/1
Message was sent while issue was closed.
Change committed as 257367
Message was sent while issue was closed.
Just FTR (and because it wasn't clear to me from the description), the output is still hard-coded to mono, but passes through GuessChannelLayout now. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
