Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2003423005: Expose a method GetRecentEffectiveConnectionType in NQE. (Closed)

Created:
4 years, 7 months ago by tbansal1
Modified:
4 years, 6 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose a method GetRecentEffectiveConnectionType in NQE. This method is private and will be used for computing the accuracy of NQE. Also, remove some duplicate code in the existing methods. BUG=615551 Committed: https://crrev.com/94f611885fe6ae218aa146c17d1df4c07e35f4af Cr-Commit-Position: refs/heads/master@{#396606}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -62 lines) Patch
M net/nqe/network_quality_estimator.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M net/nqe/network_quality_estimator.cc View 1 4 chunks +13 lines, -26 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 1 10 chunks +93 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tbansal1
bengr: ptal. thanks.
4 years, 7 months ago (2016-05-25 18:55:13 UTC) #4
bengr
lgtm
4 years, 6 months ago (2016-05-27 19:52:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003423005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003423005/20001
4 years, 6 months ago (2016-05-27 22:34:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-28 00:07:44 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 00:09:05 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94f611885fe6ae218aa146c17d1df4c07e35f4af
Cr-Commit-Position: refs/heads/master@{#396606}

Powered by Google App Engine
This is Rietveld 408576698