Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: runtime/vm/runtime_entry_arm64.cc

Issue 2003403003: ARM/ARM64: Fix smashed CODE_REG in intrinsics with InvokeMathCFunctionInstrs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | tests/lib/math/call_cmath_box_failure_path_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/runtime_entry.h" 8 #include "vm/runtime_entry.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // R5 : address of the runtime function to call. 45 // R5 : address of the runtime function to call.
46 // R4 : number of arguments to the call. 46 // R4 : number of arguments to the call.
47 void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const { 47 void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {
48 if (is_leaf()) { 48 if (is_leaf()) {
49 ASSERT(argument_count == this->argument_count()); 49 ASSERT(argument_count == this->argument_count());
50 // Since we are entering C++ code, we must restore the C stack pointer from 50 // Since we are entering C++ code, we must restore the C stack pointer from
51 // the stack limit to an aligned value nearer to the top of the stack. 51 // the stack limit to an aligned value nearer to the top of the stack.
52 // We cache the Dart stack pointer and the stack limit in callee-saved 52 // We cache the Dart stack pointer and the stack limit in callee-saved
53 // registers, then align and call, restoring CSP and SP on return from the 53 // registers, then align and call, restoring CSP and SP on return from the
54 // call. 54 // call.
55 __ mov(R24, CSP); 55 // This sequence may occur in an intrinsic, so don't use registers an
56 // intrinsic must preserve.
57 COMPILE_ASSERT(R23 != CODE_REG);
58 COMPILE_ASSERT(R25 != CODE_REG);
59 COMPILE_ASSERT(R23 != ARGS_DESC_REG);
60 COMPILE_ASSERT(R25 != ARGS_DESC_REG);
61 __ mov(R23, CSP);
56 __ mov(R25, SP); 62 __ mov(R25, SP);
57 __ ReserveAlignedFrameSpace(0); 63 __ ReserveAlignedFrameSpace(0);
58 __ mov(CSP, SP); 64 __ mov(CSP, SP);
59 __ ldr(TMP, Address(THR, Thread::OffsetFromThread(this))); 65 __ ldr(TMP, Address(THR, Thread::OffsetFromThread(this)));
60 __ blr(TMP); 66 __ blr(TMP);
61 __ mov(SP, R25); 67 __ mov(SP, R25);
62 __ mov(CSP, R24); 68 __ mov(CSP, R23);
63 } else { 69 } else {
64 // Argument count is not checked here, but in the runtime entry for a more 70 // Argument count is not checked here, but in the runtime entry for a more
65 // informative error message. 71 // informative error message.
66 __ ldr(R5, Address(THR, Thread::OffsetFromThread(this))); 72 __ ldr(R5, Address(THR, Thread::OffsetFromThread(this)));
67 __ LoadImmediate(R4, argument_count); 73 __ LoadImmediate(R4, argument_count);
68 __ BranchLinkToRuntime(); 74 __ BranchLinkToRuntime();
69 } 75 }
70 } 76 }
71 77
72 } // namespace dart 78 } // namespace dart
73 79
74 #endif // defined TARGET_ARCH_ARM64 80 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | tests/lib/math/call_cmath_box_failure_path_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698