LayoutTests/fast/events/js-keyboard-event-creation.html - Issue 20034002: Add support for KeyboardEvent.location attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/js-keyboard-event-creation.html

Issue 20034002: Add support for KeyboardEvent.location attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take Kentaro's feedback into consideration Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/init-events-expected.txt ('k') | LayoutTests/fast/events/keydown-leftright-keys.html » ('j') | Source/bindings/scripts/deprecated_code_generator_v8.pm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/js-keyboard-event-creation.html

diff --git a/LayoutTests/fast/events/js-keyboard-event-creation.html b/LayoutTests/fast/events/js-keyboard-event-creation.html

index 753d611869fe974662c984233e0d80b5a0787b12..f1526e57f16266adad526f614706c415cb802c68 100644

--- a/LayoutTests/fast/events/js-keyboard-event-creation.html

+++ b/LayoutTests/fast/events/js-keyboard-event-creation.html

@@ -4,7 +4,7 @@

function keyevent(event) {

var p = document.createElement("p");

- p.appendChild(document.createTextNode(event.type + " - key: " + event.keyIdentifier + "@" + event.keyLocation + " (keyCode/charCode: " + event.keyCode + "/" + event.charCode + ")" + " modifiers: " + event.ctrlKey + "," + event.altKey + "," + event.shiftKey + "," + event.metaKey));

+ p.appendChild(document.createTextNode(event.type + " - key: " + event.keyIdentifier + "@" + event.location + " (keyCode/charCode: " + event.keyCode + "/" + event.charCode + ")" + " modifiers: " + event.ctrlKey + "," + event.altKey + "," + event.shiftKey + "," + event.metaKey));

document.getElementById("result").appendChild(p);

}