Source/web/WebInputEventConversion.cpp - Issue 20034002: Add support for KeyboardEvent.location attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebInputEventConversion.cpp

Issue 20034002: Add support for KeyboardEvent.location attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebInputEventConversion.cpp

diff --git a/Source/web/WebInputEventConversion.cpp b/Source/web/WebInputEventConversion.cpp

index b61f9ad7e5b6ef8c1293da38536f7531f51c5149..ac156b99b7f86f47d4692fa700a9fb0ca07c2abd 100644

--- a/Source/web/WebInputEventConversion.cpp

+++ b/Source/web/WebInputEventConversion.cpp

@@ -602,11 +602,11 @@ WebKeyboardEventBuilder::WebKeyboardEventBuilder(const KeyboardEvent& event)

return; // Skip all other keyboard events.

modifiers = getWebInputModifiers(event);

- if (event.keyLocation() == KeyboardEvent::DOMKeyLocationNumpad)

+ if (event.location() == KeyboardEvent::DOMKeyLocationNumpad)

modifiers |= WebInputEvent::IsKeyPad;

- else if (event.keyLocation() == KeyboardEvent::DOMKeyLocationLeft)

+ else if (event.location() == KeyboardEvent::DOMKeyLocationLeft)

modifiers |= WebInputEvent::IsLeft;

- else if (event.keyLocation() == KeyboardEvent::DOMKeyLocationRight)

+ else if (event.location() == KeyboardEvent::DOMKeyLocationRight)

modifiers |= WebInputEvent::IsRight;

timeStampSeconds = event.timeStamp() / millisPerSecond;