Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: Source/devtools/front_end/ExtensionAPI.js

Issue 20034002: Add support for KeyboardEvent.location attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ExtensionAPI.js
diff --git a/Source/devtools/front_end/ExtensionAPI.js b/Source/devtools/front_end/ExtensionAPI.js
index dc102a5b67680cca06b1c4a9358b2a89b0852e0e..31d062c6eab765469fce0cc342857278b34cf1bb 100644
--- a/Source/devtools/front_end/ExtensionAPI.js
+++ b/Source/devtools/front_end/ExtensionAPI.js
@@ -738,7 +738,7 @@ function forwardKeyboardEvent(event)
altKey: event.altKey,
metaKey: event.metaKey,
keyIdentifier: event.keyIdentifier,
- keyLocation: event.keyLocation
+ location: event.location
arv (Not doing code reviews) 2013/07/23 17:33:22 Maybe add: get keyLocation() { return this.keyL
do-not-use 2013/07/23 19:44:03 I don't understand this comment, sorry. Since I am
arv (Not doing code reviews) 2013/07/23 20:07:16 Ignore me. I thought this was part of something pu
};
extensionServer.sendRequest(request);
}

Powered by Google App Engine
This is Rietveld 408576698