Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: Source/core/dom/KeyboardEvent.idl

Issue 20034002: Add support for KeyboardEvent.location attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/KeyboardEvent.idl
diff --git a/Source/core/dom/KeyboardEvent.idl b/Source/core/dom/KeyboardEvent.idl
index 134cb59c34afe583ffa6370a6385b796b8ca18f0..8b096b8c4a96e4e0030f5d43398e5ddebd2a2404 100644
--- a/Source/core/dom/KeyboardEvent.idl
+++ b/Source/core/dom/KeyboardEvent.idl
@@ -23,20 +23,23 @@
] interface KeyboardEvent : UIEvent {
[InitializedByEventConstructor] readonly attribute DOMString keyIdentifier;
- [InitializedByEventConstructor] readonly attribute unsigned long keyLocation;
+ [InitializedByEventConstructor] readonly attribute unsigned long location;
[InitializedByEventConstructor] readonly attribute boolean ctrlKey;
[InitializedByEventConstructor] readonly attribute boolean shiftKey;
[InitializedByEventConstructor] readonly attribute boolean altKey;
[InitializedByEventConstructor] readonly attribute boolean metaKey;
readonly attribute boolean altGraphKey;
+ // Deprecated attributes kept to maintain backward compatibility.
+ [ImplementedAs=location, DeprecateAs=KeyboardEventKeyLocation, InitializedByEventConstructor] readonly attribute unsigned long keyLocation;
haraken 2013/07/23 09:21:30 Nit: Shall we write this just below the 'location'
do-not-use 2013/07/23 10:12:04 Ok, if you prefer. I created a "deprecated" sectio
+
// FIXME: this does not match the version in the DOM spec.
void initKeyboardEvent([Default=Undefined] optional DOMString type,
[Default=Undefined] optional boolean canBubble,
[Default=Undefined] optional boolean cancelable,
[Default=Undefined] optional Window view,
[Default=Undefined] optional DOMString keyIdentifier,
- [Default=Undefined] optional unsigned long keyLocation,
+ [Default=Undefined] optional unsigned long location,
[Default=Undefined] optional boolean ctrlKey,
[Default=Undefined] optional boolean altKey,
[Default=Undefined] optional boolean shiftKey,

Powered by Google App Engine
This is Rietveld 408576698