Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2003363002: [turbofan] Properly run TypeHintAnalyzer and AstLoopAssignmentAnalyzer on inlinees. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly run TypeHintAnalyzer and AstLoopAssignmentAnalyzer on inlinees. Previously we only ran these analysis passes on the outermost function, but not on inlined functions. R=jarin@chromium.org Committed: https://crrev.com/3f8de190f99e247626efa98dd8247eb81259c484 Cr-Commit-Position: refs/heads/master@{#36474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/compiler/js-inlining.cc View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-24 11:55:53 UTC) #1
Jarin
lgtm
4 years, 7 months ago (2016-05-24 11:57:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003363002/1
4 years, 7 months ago (2016-05-24 11:57:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 12:29:00 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 12:30:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f8de190f99e247626efa98dd8247eb81259c484
Cr-Commit-Position: refs/heads/master@{#36474}

Powered by Google App Engine
This is Rietveld 408576698