Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: chrome/chrome_resources.gyp

Issue 2003323003: Script to push download_file_types.pb to all platforms, via Component Updater (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit in README.gn Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_resources.gyp
diff --git a/chrome/chrome_resources.gyp b/chrome/chrome_resources.gyp
index ff94d953db3dbe146dc7cad4f2194051393ba476..daf559bad5c001ed58480263254373ed90427257 100644
--- a/chrome/chrome_resources.gyp
+++ b/chrome/chrome_resources.gyp
@@ -313,7 +313,8 @@
'variables' : {
'script_file':'browser/resources/safe_browsing/gen_file_type_proto.py',
'asciipb_file' : 'browser/resources/safe_browsing/download_file_types.asciipb',
- 'output_file' : '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/safe_browsing/download_file_types.pb',
+ 'output_dir' : '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/safe_browsing',
+ 'output_basename' : 'download_file_types.pb',
'conditions': [
['OS=="android"', {
'platform': 'android'
@@ -336,14 +337,15 @@
'<(asciipb_file)',
],
'outputs': [
- '<(output_file)',
+ '<(output_dir)/<(output_basename)',
],
'action': [
'python',
'<(script_file)',
'-w',
'-i', '<(asciipb_file)',
- '-o', '<(output_file)',
+ '-d', '<(output_dir)',
+ '-o', '<(output_basename)',
'-t', '<(platform)',
'-p', '<(PRODUCT_DIR)/pyproto',
'-p', '<(PRODUCT_DIR)/pyproto/chrome/common/safe_browsing',

Powered by Google App Engine
This is Rietveld 408576698