Remove inessential functions from the JS Script class

Remove inessential functions from the JS Script class

Moved functionality of Script.{lineCount, lineFromPosition, sourceLine,
locationFromLine, and sourceSlice} into runtime functions.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/9ffedb50d5acb24338e545309075bf2b4d98ab14
Cr-Commit-Position: refs/heads/master@{#36469}

[jgruber, 2016-05-24 07:08:36]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 07:08:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003303002/1

[commit-bot: I haz the power, 2016-05-24 07:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 07:43:33]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-05-24 07:54:31]

LGTM with comments.

https://codereview.chromium.org/2003303002/diff/1/src/debug/debug.js
File src/debug/debug.js (right):

https://codereview.chromium.org/2003303002/diff/1/src/debug/debug.js#newcode550
src/debug/debug.js:550: return %ScriptLocationFromLine(script, line, column,
script_offset);
We could include the undefined handling in %ScriptLocationFromLine. That way we
won't have the duplicate below.

https://codereview.chromium.org/2003303002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/2003303002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1565: static Object*
GetJSPositionInfo(Handle<Script> script, int position,
Let's return a handle and let the call site dereference it.

[jgruber, 2016-05-24 10:51:55]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 10:52:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003303002/20001

[jgruber, 2016-05-24 10:52:55]

https://codereview.chromium.org/2003303002/diff/1/src/debug/debug.js
File src/debug/debug.js (right):

https://codereview.chromium.org/2003303002/diff/1/src/debug/debug.js#newcode550
src/debug/debug.js:550: return %ScriptLocationFromLine(script, line, column,
script_offset);
On 2016/05/24 07:54:31, Yang wrote:
> We could include the undefined handling in %ScriptLocationFromLine. That way
we
> won't have the duplicate below.

Done.

https://codereview.chromium.org/2003303002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/2003303002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1565: static Object*
GetJSPositionInfo(Handle<Script> script, int position,
On 2016/05/24 07:54:31, Yang wrote:
> Let's return a handle and let the call site dereference it.

Done.

[commit-bot: I haz the power, 2016-05-24 11:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 11:24:22]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-05-24 11:36:42]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-05-24 11:36:43]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2003303002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-05-24 11:36:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003303002/20001

[commit-bot: I haz the power, 2016-05-24 11:39:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-24 11:41:33]

Description was changed from

==========
Remove inessential functions from the JS Script class

Moved functionality of Script.{lineCount, lineFromPosition, sourceLine,
locationFromLine, and sourceSlice} into runtime functions.

R=yangguo@chromium.org
BUG=
==========

to

==========
Remove inessential functions from the JS Script class

Moved functionality of Script.{lineCount, lineFromPosition, sourceLine,
locationFromLine, and sourceSlice} into runtime functions.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/9ffedb50d5acb24338e545309075bf2b4d98ab14
Cr-Commit-Position: refs/heads/master@{#36469}
==========

[commit-bot: I haz the power, 2016-05-24 11:41:34]

Patchset 2 (id:??) landed as
https://crrev.com/9ffedb50d5acb24338e545309075bf2b4d98ab14
Cr-Commit-Position: refs/heads/master@{#36469}