Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2003293003: [Binding] [UMA] Add a UMA to track time spent in WindowProxy::initialize (Closed)

Created:
4 years, 7 months ago by peria
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a user metric to track time spent in WindowProxy::initialize to track how efficiently we will reduce it. BUG=325923, 588893 Committed: https://crrev.com/0a34f2d8be5cf7d5545de5fdc59057c320a9165e Cr-Commit-Position: refs/heads/master@{#395810}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
peria
kouhei@, could you check if it measures what we want before requesting OWNERs' reviews?
4 years, 7 months ago (2016-05-24 08:09:14 UTC) #4
kouhei (in TOK)
https://codereview.chromium.org/2003293003/diff/20001/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp File third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp (right): https://codereview.chromium.org/2003293003/diff/20001/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp#newcode229 third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:229: double startTime = currentTimeMS(); use monotonicallyIncreasingTime() instead of currentTimeMS, ...
4 years, 7 months ago (2016-05-24 09:08:12 UTC) #5
peria
PTL https://codereview.chromium.org/2003293003/diff/20001/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp File third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp (right): https://codereview.chromium.org/2003293003/diff/20001/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp#newcode229 third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:229: double startTime = currentTimeMS(); On 2016/05/24 09:08:12, kouhei ...
4 years, 7 months ago (2016-05-24 09:36:24 UTC) #7
Yuki
LGTM on my side, though I don't really know much about UMA.
4 years, 7 months ago (2016-05-24 10:09:34 UTC) #8
kouhei (in TOK)
lgtm
4 years, 7 months ago (2016-05-24 10:37:49 UTC) #9
haraken
LGTM
4 years, 7 months ago (2016-05-24 14:06:30 UTC) #11
peria
holte@, could you take a look as an OWNER of tools/metics?
4 years, 7 months ago (2016-05-24 17:45:23 UTC) #13
Steven Holte
lgtm
4 years, 7 months ago (2016-05-24 18:11:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003293003/40001
4 years, 7 months ago (2016-05-25 00:41:28 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-25 05:50:08 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 05:51:34 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a34f2d8be5cf7d5545de5fdc59057c320a9165e
Cr-Commit-Position: refs/heads/master@{#395810}

Powered by Google App Engine
This is Rietveld 408576698