Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2003273002: X87: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word compariso… (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #1 id:1 of https://codereview.chromium.org/1968453002/ ). port 767c34dfae4b0e523c38b0f44e1db70b603d41bf (r36413) original commit message: Reason for revert: Breaks a KCS demo: BUG=chromium:611976 Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in http://crrev.com/1962563003. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use > > Committed: https://crrev.com/2da70f853d7f680d491c37c72d5ef04a85497ba9 > Cr-Commit-Position: refs/heads/master@{#36136} Committed: https://crrev.com/35e0f01fb9e9d191663e2993031829db38e706b5 Cr-Commit-Position: refs/heads/master@{#36456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -58 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 3 chunks +13 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-24 03:52:34 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-24 03:54:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003273002/1
4 years, 7 months ago (2016-05-24 03:55:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 04:16:41 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 04:19:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35e0f01fb9e9d191663e2993031829db38e706b5
Cr-Commit-Position: refs/heads/master@{#36456}

Powered by Google App Engine
This is Rietveld 408576698