Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2003253002: [Devtools] Allow User-Agent header override for Websockets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
index 31a9361ad76df2c9c4d11df5a99457d277fcd189..4e4d747af2123b58d1bb9b3a39dbc9f9a1222025 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
@@ -904,8 +904,12 @@ void InspectorNetworkAgent::disable(ErrorString*)
m_knownRequestIdMap.clear();
}
-void InspectorNetworkAgent::setUserAgentOverride(ErrorString*, const String& userAgent)
+void InspectorNetworkAgent::setUserAgentOverride(ErrorString* errorString, const String& userAgent)
{
+ if (userAgent.contains('\n') || userAgent.contains('\r') || userAgent.contains('\0')) {
+ *errorString = "Invalid characters found in userAgent";
+ return;
+ }
m_state->setString(NetworkAgentState::userAgentOverride, userAgent);
}

Powered by Google App Engine
This is Rietveld 408576698