third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp - Issue 2003253002: [Devtools] Allow User-Agent header override for Websockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2003253002: [Devtools] Allow User-Agent header override for Websockets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector-protocol/websocket/websocket-user-agent-override.html ('K') | « third_party/WebKit/LayoutTests/http/tests/inspector-protocol/websocket/websocket-user-agent-override-expected.txt ('k') | third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

index 31a9361ad76df2c9c4d11df5a99457d277fcd189..4e4d747af2123b58d1bb9b3a39dbc9f9a1222025 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

@@ -904,8 +904,12 @@ void InspectorNetworkAgent::disable(ErrorString*)

m_knownRequestIdMap.clear();

}

-void InspectorNetworkAgent::setUserAgentOverride(ErrorString*, const String& userAgent)

+void InspectorNetworkAgent::setUserAgentOverride(ErrorString* errorString, const String& userAgent)

{

+ if (userAgent.contains('\n') || userAgent.contains('\r') || userAgent.contains('\0')) {

+ *errorString = "Invalid characters found in userAgent";

+ return;

+ }

m_state->setString(NetworkAgentState::userAgentOverride, userAgent);

}