net/websockets/websocket_channel_test.cc - Issue 2003253002: [Devtools] Allow User-Agent header override for Websockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_channel_test.cc

Issue 2003253002: [Devtools] Allow User-Agent header override for Websockets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/websockets/websocket_channel.cc ('k') | net/websockets/websocket_end_to_end_test.cc » ('j') | third_party/WebKit/LayoutTests/http/tests/inspector-protocol/websocket/websocket-user-agent-override.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/websockets/websocket_channel_test.cc

diff --git a/net/websockets/websocket_channel_test.cc b/net/websockets/websocket_channel_test.cc

index 040a903f9ab836817e42f7b291ac50c64c1fdb8b..a6b15e63b9df6d90dcdaeaa4ae4495288352a04b 100644

--- a/net/websockets/websocket_channel_test.cc

+++ b/net/websockets/websocket_channel_test.cc

@@ -699,6 +699,7 @@ struct ArgumentCopyingWebSocketStreamCreator {

const GURL& socket_url,

const std::vector<std::string>& requested_subprotocols,

const url::Origin& origin,

+ const std::string& additional_headers,

URLRequestContext* url_request_context,

const BoundNetLog& net_log,

std::unique_ptr<WebSocketStream::ConnectDelegate> connect_delegate) {

@@ -744,9 +745,8 @@ class WebSocketChannelTest : public ::testing::Test {

channel_.reset(new WebSocketChannel(CreateEventInterface(),

&connect_data_.url_request_context));

channel_->SendAddChannelRequestForTesting(

- connect_data_.socket_url,

- connect_data_.requested_subprotocols,

- connect_data_.origin,

+ connect_data_.socket_url, connect_data_.requested_subprotocols,

+ connect_data_.origin, "",

base::Bind(&ArgumentCopyingWebSocketStreamCreator::Create,

base::Unretained(&connect_data_.creator)));

}