third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h - Issue 2003253002: [Devtools] Allow User-Agent header override for Websockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

Issue 2003253002: [Devtools] Allow User-Agent header override for Websockets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-protocol/websocket/websocket-user-agent-override-expected.txt ('k') | third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp » ('j') | third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

diff --git a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

index ae65566583971701f5c7d1311dcf02fa8e0fca41..9c9ffe5e05a121fcfd6eedd3cd2e59feea72554a 100644

--- a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

+++ b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

@@ -131,6 +131,8 @@ private:

void didFinishLoadingBlob(DOMArrayBuffer*);

void didFailLoadingBlob(FileError::ErrorCode);

+ const WebString additionalHeaders();

yhirano 2016/05/30 11:12:57 Can you tell me why you use WebString instead of S

yhirano 2016/05/30 11:12:57 |const| not needed?

allada 2016/06/01 19:06:41 Done.

// m_handle is a handle of the connection.

// m_handle == 0 means this channel is closed.

OwnPtr<WebSocketHandle> m_handle;