Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2003233002: Replace how we generate sdk.json to use directly the compiler API without using (Closed)

Created:
4 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 7 months ago
Reviewers:
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace how we generate sdk.json to use directly the compiler API without using source-mirrors. This is the last use of source-mirrors in the repo.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -76 lines) Patch
M pkg/compiler/samples/jsonify/jsonify.dart View 1 chunk +234 lines, -74 lines 0 comments Download
M site/try/build_try.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Siggi Cherem (dart-lang)
4 years, 7 months ago (2016-05-24 17:04:06 UTC) #3
Message was sent while issue was closed.
marking as closed: we decided to use a different approach. See
https://codereview.chromium.org/2006993002/.

Powered by Google App Engine
This is Rietveld 408576698