Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2003193002: Add cros_{target,host,v8_snapshot}_{nm,readelf} vars to GN build. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
stevenjb, llozano
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cros_{target,host,v8_snapshot}_{nm,readelf} vars to GN build. So that the CrOS ebuild builds can customize paths to nm and readelf as needed. R=stevenjb@chromium.org, llozano@chromium.org BUG=608596 Committed: https://crrev.com/5d3de89f668f8e8923a8baa70e1e2b31b5a72fd0 Cr-Commit-Position: refs/heads/master@{#395505}

Patch Set 1 #

Patch Set 2 : fix snapshot typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M build/toolchain/cros/BUILD.gn View 1 6 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Dirk Pranke
4 years, 7 months ago (2016-05-23 21:59:46 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003193002/1
4 years, 7 months ago (2016-05-23 22:00:06 UTC) #5
stevenjb
lgtm
4 years, 7 months ago (2016-05-23 22:04:05 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/141955)
4 years, 7 months ago (2016-05-23 22:06:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003193002/20001
4 years, 7 months ago (2016-05-23 22:53:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 01:32:36 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 01:34:56 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d3de89f668f8e8923a8baa70e1e2b31b5a72fd0
Cr-Commit-Position: refs/heads/master@{#395505}

Powered by Google App Engine
This is Rietveld 408576698