Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2003063003: Add a null check in ConnectivityManagerDelegate.getNetworkState (Closed)

Created:
4 years, 7 months ago by xunjieli
Modified:
4 years, 7 months ago
Reviewers:
pauljensen, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Add a null check in ConnectivityManagerDelegate.getNetworkState ConnectivityManager.getNetworkInfo can return null if the Network is invalid. This CL adds a null check so we don't crash with a NullPointerException when invoking networkInfo.getType() BUG=613599 TBR=mef@chromium.org,pauljensen@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2003503003 Cr-Commit-Position: refs/heads/master@{#395375} (cherry picked from commit ff2ec75896222f8a2ddc6b9e1551276929a0b671)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 1 chunk +1 line, -1 line 0 comments Download
M net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
xunjieli
4 years, 7 months ago (2016-05-23 19:32:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003063003/1
4 years, 7 months ago (2016-05-23 19:32:52 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-23 19:32:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003063003/1
4 years, 7 months ago (2016-05-23 19:35:31 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 19:37:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698