Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2003033004: Split custom element script use and move it into bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
index 64b37d7d97787550875b90d4fd4d77bcbee67132..e410349ac24f66484daacbb7c199e68be1822b60 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
@@ -5,35 +5,26 @@
#ifndef CustomElementDefinition_h
#define CustomElementDefinition_h
-#include "bindings/core/v8/ScopedPersistent.h"
+#include "core/CoreExport.h"
#include "core/dom/custom/CustomElementDescriptor.h"
-#include "core/dom/custom/CustomElementsRegistry.h"
#include "platform/heap/Handle.h"
-#include "v8.h"
+#include "wtf/Noncopyable.h"
namespace blink {
-class CustomElementDefinition final
+class CORE_EXPORT CustomElementDefinition
: public GarbageCollectedFinalized<CustomElementDefinition> {
+ WTF_MAKE_NONCOPYABLE(CustomElementDefinition);
public:
- CustomElementDefinition(
- CustomElementsRegistry*,
- CustomElementsRegistry::Id,
- const CustomElementDescriptor&);
+ CustomElementDefinition(const CustomElementDescriptor&);
+ virtual ~CustomElementDefinition();
- CustomElementsRegistry::Id id() const { return m_id; }
const CustomElementDescriptor& descriptor() { return m_descriptor; }
- v8::Local<v8::Object> prototype(ScriptState*) const;
- DEFINE_INLINE_TRACE()
- {
- visitor->trace(m_registry);
- }
+ DEFINE_INLINE_VIRTUAL_TRACE() { }
private:
- Member<CustomElementsRegistry> m_registry;
- CustomElementsRegistry::Id m_id;
- CustomElementDescriptor m_descriptor;
+ const CustomElementDescriptor m_descriptor;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698