Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

Issue 2003033004: Split custom element script use and move it into bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp
index c0a526de2fc639a1b0662b3c784fca9f164d949e..2f9ed0437bfe3009ccf01fea01046813b08efb51 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp
@@ -6,12 +6,12 @@
#include "bindings/core/v8/DOMWrapperWorld.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/ScriptCustomElementDefinition.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8BindingMacros.h"
#include "bindings/core/v8/V8DOMWrapper.h"
#include "bindings/core/v8/V8ThrowException.h"
#include "core/dom/Document.h"
-#include "core/dom/custom/CustomElementDefinition.h"
#include "core/dom/custom/CustomElementsRegistry.h"
#include "core/frame/LocalDOMWindow.h"
#include "platform/RuntimeEnabledFeatures.h"
@@ -33,9 +33,10 @@ void V8HTMLElement::constructorCustom(
}
LocalDOMWindow* window = scriptState->domWindow();
- CustomElementDefinition* def =
- window->customElements(scriptState)->definitionForConstructor(
+ ScriptCustomElementDefinition* def =
+ ScriptCustomElementDefinition::forConstructor(
scriptState,
+ window->customElements(),
info.NewTarget());
if (!def) {
V8ThrowException::throwTypeError(isolate, "Illegal constructor");

Powered by Google App Engine
This is Rietveld 408576698