Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2003033002: Revert InstrumentingAgents back to being GarbageCollected<>. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert InstrumentingAgents back to being GarbageCollected<>. Unnecessary to have this class be finalized, so switch back to GarbageCollected<>. R= BUG= Committed: https://crrev.com/e866443cc0280b421dd7527a737e5acdfc631bd7 Cr-Commit-Position: refs/heads/master@{#395446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-23 15:33:05 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-23 17:07:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003033002/1
4 years, 7 months ago (2016-05-23 18:28:42 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-23 21:10:42 UTC) #7
sof
On 2016/05/23 21:10:42, haraken wrote: > LGTM hmm, what timezone is this from? :-)
4 years, 7 months ago (2016-05-23 21:13:30 UTC) #8
haraken
On 2016/05/23 21:13:30, sof wrote: > On 2016/05/23 21:10:42, haraken wrote: > > LGTM > ...
4 years, 7 months ago (2016-05-23 21:17:59 UTC) #9
sof
On 2016/05/23 21:17:59, haraken wrote: > On 2016/05/23 21:13:30, sof wrote: > > On 2016/05/23 ...
4 years, 7 months ago (2016-05-23 21:27:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 22:53:24 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 22:58:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e866443cc0280b421dd7527a737e5acdfc631bd7
Cr-Commit-Position: refs/heads/master@{#395446}

Powered by Google App Engine
This is Rietveld 408576698