Update launcher API.

Update launcher API.

Allow caller to specify the native viewport to launch the application
on.

R=ppi@chromium.org, jeffbrown@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/8188f0dfd609f0212bd427cfe1a0c2ce435f1e46

[qsr, 2016-05-26 07:21:06]

Gentle ping?

[qsr, 2016-05-27 07:05:46]

qsr@chromium.org changed reviewers:
+ ppi@chromium.org

[qsr, 2016-05-27 07:05:47]

+ppi

[ppi, 2016-05-30 09:21:00]

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
File services/ui/launcher/launcher.mojom (right):

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
services/ui/launcher/launcher.mojom:15: LaunchOnViewport(mojo.NativeViewport
viewport,
Should we annotate this method with a comment along the lines of
https://github.com/domokit/mojo/commit/8d66e0d091ffaf332a1ea75d6c37232ad9f3ec36
?

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
File services/ui/launcher/launcher_app.cc (right):

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
services/ui/launcher/launcher_app.cc:108: DVLOG(1) << "Launching" <<
application_url;
Need a space after "Launching"

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
services/ui/launcher/launcher_app.cc:114:
LaunchInternal(mojo::NativeViewportPtr(), view_provider.Pass());
Should we get the native viewport from mojo:native_viewport_service here, and
thus later avoid the condition in LaunchInstance::InitViewport() ?

[qsr, 2016-05-30 09:37:57]

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
File services/ui/launcher/launcher.mojom (right):

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
services/ui/launcher/launcher.mojom:15: LaunchOnViewport(mojo.NativeViewport
viewport,
On 2016/05/30 09:21:00, ppi wrote:
> Should we annotate this method with a comment along the lines of
>
https://github.com/domokit/mojo/commit/8d66e0d091ffaf332a1ea75d6c37232ad9f3ec36
> ?

Done.

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
File services/ui/launcher/launcher_app.cc (right):

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
services/ui/launcher/launcher_app.cc:108: DVLOG(1) << "Launching" <<
application_url;
On 2016/05/30 09:21:00, ppi wrote:
> Need a space after "Launching"

Done.

https://codereview.chromium.org/2003003002/diff/60001/services/ui/launcher/la...
services/ui/launcher/launcher_app.cc:114:
LaunchInternal(mojo::NativeViewportPtr(), view_provider.Pass());
On 2016/05/30 09:21:00, ppi wrote:
> Should we get the native viewport from mojo:native_viewport_service here, and
> thus later avoid the condition in LaunchInstance::InitViewport() ?

Done.

[ppi, 2016-05-30 09:44:45]

lgtm % comment

https://codereview.chromium.org/2003003002/diff/80001/services/ui/launcher/la...
File services/ui/launcher/launcher.mojom (right):

https://codereview.chromium.org/2003003002/diff/80001/services/ui/launcher/la...
services/ui/launcher/launcher.mojom:15: // Allows to displays the view provided
by |view_provider| in the provider
s/displays/display/, but even better s/Allows to//. And  s/provider/provided/ at
the end IIUC.

[qsr, 2016-05-30 09:46:32]

https://codereview.chromium.org/2003003002/diff/80001/services/ui/launcher/la...
File services/ui/launcher/launcher.mojom (right):

https://codereview.chromium.org/2003003002/diff/80001/services/ui/launcher/la...
services/ui/launcher/launcher.mojom:15: // Allows to displays the view provided
by |view_provider| in the provider
On 2016/05/30 09:44:45, ppi wrote:
> s/displays/display/, but even better s/Allows to//. And  s/provider/provided/
at
> the end IIUC.

Done.

[qsr, 2016-05-30 09:47:31]

Description was changed from

==========
Update launcher API.

Allow caller to specify the native viewport to launch the application
on.

R=jeffbrown@google.com
==========

to

==========
Update launcher API.

Allow caller to specify the native viewport to launch the application
on.

R=ppi@chromium.org, jeffbrown@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/8188f0dfd609f0212bd427cfe1a...
==========

[qsr, 2016-05-30 09:47:33]

Committed patchset #6 (id:100001) manually as
8188f0dfd609f0212bd427cfe1a0c2ce435f1e46 (presubmit successful).