Issue 20030004: Make DataView setters throw when only offset is provided.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20030004: Make DataView setters throw when only offset is provided. (Closed)

Created:
7 years, 5 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 5 months ago

Reviewers:
Benedikt Meurer, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Make DataView setters throw when only offset is provided. Also fix typo in error message id. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15865

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -26 lines)			Patch
	M	src/typedarray.js	View		19 chunks	+26 lines, -26 lines	0 comments	Download
	M	test/mjsunit/harmony/dataview-accessors.js	View		2 chunks	+38 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Lomov (no reviews)

Please take a look. These are (very unfortunate) typos, basically.

7 years, 5 months ago (2013-07-24 15:44:15 UTC) #1

Dmitry Lomov (no reviews)

7 years, 5 months ago (2013-07-24 17:35:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15865 (presubmit successful).