Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2002993002: Refactor script position calculation (Closed)

Created:
4 years, 7 months ago by jgruber
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor script position calculation Script position calculation logic (i.e. line & column numbers for a given code position) is now based on a single method Script::GetPositionInfo(). Refactored related code in isolate.cc and js/messages.js to use the new method. The line_ends accessor is still in use by chromium and thus cannot be removed yet. R=yangguo@chromium.org BUG= Committed: https://crrev.com/94ad3b1826fdd08866213220e9ef24d981ed0399 Cr-Commit-Position: refs/heads/master@{#36458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -219 lines) Patch
M src/debug/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-symbols.h View 4 chunks +5 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +7 lines, -18 lines 0 comments Download
M src/js/messages.js View 9 chunks +19 lines, -122 lines 0 comments Download
M src/objects.h View 2 chunks +27 lines, -8 lines 0 comments Download
M src/objects.cc View 1 chunk +78 lines, -27 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +82 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +38 lines, -43 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002993002/1
4 years, 7 months ago (2016-05-23 11:48:02 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 12:20:12 UTC) #4
jgruber
One more time around. The previous version of this patch caused crashes on gc-stress bots ...
4 years, 7 months ago (2016-05-23 13:11:01 UTC) #5
Yang
On 2016/05/23 13:11:01, jgruber1 wrote: > One more time around. The previous version of this ...
4 years, 7 months ago (2016-05-23 18:25:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002993002/1
4 years, 7 months ago (2016-05-24 06:37:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 06:40:17 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 06:42:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94ad3b1826fdd08866213220e9ef24d981ed0399
Cr-Commit-Position: refs/heads/master@{#36458}

Powered by Google App Engine
This is Rietveld 408576698