third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h - Issue 2002943002: CSP violation reports should report the pre-redirect URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

Issue 2002943002: CSP violation reports should report the pre-redirect URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/mixedContent/strict-mode-image-reportonly.https.php ('k') | third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

diff --git a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h b/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

index 2d71231ca98d83f694d6808283e0b92e22776b4e..82ee44e43d217e536416b62dc6f8e839d5559923 100644

--- a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

+++ b/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h

@@ -73,7 +73,7 @@ public:

bool allowDynamic() const;

bool strictMixedContentChecking() const { return m_strictMixedContentCheckingEnforced; }

- void reportMixedContent(const KURL& mixedURL) const;

+ void reportMixedContent(const KURL& mixedURL, ResourceRequest::RedirectStatus) const;

const String& evalDisabledErrorMessage() const { return m_evalDisabledErrorMessage; }

ReflectedXSSDisposition getReflectedXSSDisposition() const { return m_reflectedXSSDisposition; }

@@ -111,7 +111,7 @@ private:

SourceListDirective* operativeDirective(SourceListDirective*) const;

SourceListDirective* operativeDirective(SourceListDirective*, SourceListDirective* override) const;

- void reportViolation(const String& directiveText, const String& effectiveDirective, const String& consoleMessage, const KURL& blockedURL) const;

+ void reportViolation(const String& directiveText, const String& effectiveDirective, const String& consoleMessage, const KURL& blockedURL, ResourceRequest::RedirectStatus) const;

void reportViolationWithFrame(const String& directiveText, const String& effectiveDirective, const String& consoleMessage, const KURL& blockedURL, LocalFrame*) const;

void reportViolationWithLocation(const String& directiveText, const String& effectiveDirective, const String& consoleMessage, const KURL& blockedURL, const String& contextURL, const WTF::OrdinalNumber& contextLine) const;

void reportViolationWithState(const String& directiveText, const String& effectiveDirective, const String& message, const KURL& blockedURL, ScriptState*, const ContentSecurityPolicy::ExceptionStatus) const;