src/api.cc - Issue 2002933002: [json] move json parser and stringifier into own compilation units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 2002933002: [json] move json parser and stringifier into own compilation units. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index f511a5803ac22766793f905a3ecd8bca1039c8d9..416034f09da789e3b42911ecfa153a9f96129475 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -40,6 +40,7 @@

#include "src/icu_util.h"

#include "src/isolate-inl.h"

#include "src/json-parser.h"

+#include "src/json-stringifier.h"

#include "src/messages.h"

#include "src/parsing/parser.h"

#include "src/parsing/scanner-character-streams.h"

@@ -2777,9 +2778,9 @@ MaybeLocal<String> JSON::Stringify(Local<Context> context,

? isolate->factory()->empty_string()

: Utils::OpenHandle(*gap);

i::Handle<i::Object> maybe;

- has_pending_exception =

- !i::Runtime::BasicJsonStringify(isolate, object, gap_string)

- .ToHandle(&maybe);

+ has_pending_exception = !i::BasicJsonStringifier(isolate, gap_string)

+ .Stringify(object)

+ .ToHandle(&maybe);

RETURN_ON_FAILED_EXECUTION(String);

Local<String> result;

has_pending_exception =

« no previous file with comments | « BUILD.gn ('k') | src/json-parser.h » ('j') | no next file with comments »