BUILD.gn - Issue 2002933002: [json] move json parser and stringifier into own compilation units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 2002933002: [json] move json parser and stringifier into own compilation units. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 77b16216fcb0edc292756b34e1e4f41be73d52fe..83e44d71223f6bebac76b2d5ecd7803c84337246 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -1264,7 +1264,9 @@ v8_source_set("v8_base") {

"src/isolate-inl.h",

"src/isolate.cc",

"src/isolate.h",

+ "src/json-parser.cc",

"src/json-parser.h",

+ "src/json-stringifier.cc",

"src/json-stringifier.h",

"src/keys.cc",

"src/keys.h",

@@ -2102,7 +2104,10 @@ executable("d8") {

}

-if ((current_toolchain == host_toolchain && v8_toolset_for_shell == "host") || (current_toolchain == v8_snapshot_toolchain && v8_toolset_for_shell == "host") || (current_toolchain != host_toolchain && v8_toolset_for_shell == "target")) {

+if ((current_toolchain == host_toolchain && v8_toolset_for_shell == "host") ||

+ (current_toolchain == v8_snapshot_toolchain &&

+ v8_toolset_for_shell == "host") ||

+ (current_toolchain != host_toolchain && v8_toolset_for_shell == "target")) {

executable("v8_shell") {

sources = [

"samples/shell.cc",

« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »