Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20029004: Initial call for DriveAppRegistry::Update should wait for notification start-up. (Closed)

Created:
7 years, 5 months ago by kinaba
Modified:
7 years, 5 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Roger Tawa OOO till Jul 10th
Visibility:
Public.

Description

Initial call for DriveAppRegistry::Update should wait for notification start-up. This is mainly for throttling DriveIntegrationService in irrelevant unit tests. Before this patch, creation of a profile always lead to a HTTP request originates from this Update(), but that introduce some dependencies to other test cases using TestingBrowserProcess. BUG=none R=hidehiko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213102

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/chromeos/drive/drive_integration_service.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
kinaba
+hidehiko, ptal. I checked that DriveNotificationManager will not be enabled during unit tests, so the ...
7 years, 5 months ago (2013-07-23 08:39:33 UTC) #1
hidehiko
lgtm
7 years, 5 months ago (2013-07-23 09:03:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/20029004/2001
7 years, 5 months ago (2013-07-23 09:22:47 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=151145
7 years, 5 months ago (2013-07-23 10:24:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/20029004/2001
7 years, 5 months ago (2013-07-23 11:03:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=151181
7 years, 5 months ago (2013-07-23 11:40:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/20029004/2001
7 years, 5 months ago (2013-07-23 12:02:11 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=151209
7 years, 5 months ago (2013-07-23 12:48:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/20029004/2001
7 years, 5 months ago (2013-07-23 13:21:43 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=151288
7 years, 5 months ago (2013-07-23 14:16:34 UTC) #10
kinaba
7 years, 5 months ago (2013-07-23 14:30:15 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 manually as r213102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698