Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2002833005: [interpreter] Add BytecodeGenerator::Abort(). (Closed)

Created:
4 years, 7 months ago by oth
Modified:
4 years, 7 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add BytecodeGenerator::Abort(). Add a method to emit abort for code which should not be reachable. BUG=v8:4280 LOG=N Committed: https://crrev.com/8d5d9e18ea6a75929f8efb9b4130b83bca7c165c Cr-Commit-Position: refs/heads/master@{#36438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/interpreter/bytecode-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
oth
Ross, PTAL. This was an omission in the CL that prevented emitting Bytecode::kIllegal. It was ...
4 years, 7 months ago (2016-05-23 11:05:42 UTC) #2
rmcilroy
I don't think the description is accurate - it should be "for code which shouldn't ...
4 years, 7 months ago (2016-05-23 11:09:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002833005/1
4 years, 7 months ago (2016-05-23 11:20:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 11:51:44 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 11:53:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d5d9e18ea6a75929f8efb9b4130b83bca7c165c
Cr-Commit-Position: refs/heads/master@{#36438}

Powered by Google App Engine
This is Rietveld 408576698