Issue 2002823002: Preserve LICM information for check instructions during assertion strengthening.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2002823002: Preserve LICM information for check instructions during assertion strengthening. (Closed)

Created:
4 years, 7 months ago by Florian Schneider

Modified:
4 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Preserve LICM information for check instructions during assertion strengthening. This fixes potential excessive deoptimizations in checked mode. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/cb6b40d62b48d051774f5d07b6cbdc7a4c88121a

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_type_propagator.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	runtime/vm/intermediate_language.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 7 months ago (2016-05-21 17:32:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cb6b40d62b48d051774f5d07b6cbdc7a4c88121a (presubmit successful).