Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2002803002: DevTools: allow focus to be restored to the drawer when dialog closes (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow focus to be restored to the drawer after resize BUG=609013 Committed: https://crrev.com/8a6c91ecf6b62e973e5b9cd4fb6e41735f1e9b1f Cr-Commit-Position: refs/heads/master@{#395449}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unecessary brackets #

Patch Set 3 : Address patch comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Drawer.js View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
luoe
Tests coming soon in another patch
4 years, 7 months ago (2016-05-21 01:03:53 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/2002803002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js File third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js (right): https://codereview.chromium.org/2002803002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js#newcode412 third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js:412: if (this._drawer.hasFocus()) { style 1: the if blocks ...
4 years, 7 months ago (2016-05-23 18:19:24 UTC) #4
luoe
https://codereview.chromium.org/2002803002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js File third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js (right): https://codereview.chromium.org/2002803002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js#newcode412 third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js:412: if (this._drawer.hasFocus()) { On 2016/05/23 18:19:24, lushnikov wrote: > ...
4 years, 7 months ago (2016-05-23 19:18:41 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002803002/40001
4 years, 7 months ago (2016-05-23 19:19:03 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 22:59:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002803002/40001
4 years, 7 months ago (2016-05-23 23:02:14 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-23 23:08:15 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 23:09:59 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a6c91ecf6b62e973e5b9cd4fb6e41735f1e9b1f
Cr-Commit-Position: refs/heads/master@{#395449}

Powered by Google App Engine
This is Rietveld 408576698