Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Issue 20028: Fix a crash where we would try to add a DocumentMarker with a... (Closed)

Created:
11 years, 10 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a crash where we would try to add a DocumentMarker with the same start- and endOffset, which AddMarker in WebKit will ignore. As a result, our marker vector is empty and we try to access the element with index -1. Also added a check to avoid a NOTREACHED in debug build, which can happen under normal circumstances (when you navigate away from a page when a search is in progress). BUG=http://crbug.com/7250 TEST=We don't have reproduction steps for the crash but if we stop seeing this on our crash server we'll know that it is fixed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M webkit/glue/webframe_impl.cc View 2 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
11 years, 10 months ago (2009-02-03 21:18:01 UTC) #1
sky
11 years, 10 months ago (2009-02-03 21:23:59 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698