ios/chrome/app/resources/history/other_devices.js - Issue 2002783002: Use plural formats and native digits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/app/resources/history/other_devices.js

Issue 2002783002: Use plural formats and native digits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plural: use "=1" instead of "one" for pop-up block infobar Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/app/resources/history/other_devices.js

diff --git a/ios/chrome/app/resources/history/other_devices.js b/ios/chrome/app/resources/history/other_devices.js

index 8f46192d61f9a8a62b9171c7ab579c3410fbc6a7..58171abbb377edb4af7cdaa51b7a6250c675f93a 100644

--- a/ios/chrome/app/resources/history/other_devices.js

+++ b/ios/chrome/app/resources/history/other_devices.js

@@ -297,7 +297,9 @@ Device.prototype.createSessionContents_ = function(maxNumTabs) {

moreLink.classList.add('device-show-more-tabs');

moreLink.addEventListener('click', this.view_.increaseRowHeight.bind(

this.view_, this.row_, numTabsHidden));

- moreLink.textContent = loadTimeData.getStringF('xMore', numTabsHidden);

+ // TODO(jshin): Use plural message formatter when available in JS.

+ moreLink.textContent = loadTimeData.getStringF('xMore',

+ numTabsHidden.toLocaleString());

var moreWrapper = createElementWithClassName('div', 'more-wrapper');

moreWrapper.appendChild(moreLink);

contents.appendChild(moreWrapper);