Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc

Issue 2002783002: Use plural formats and native digits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: plural: use "=1" instead of "one" for pop-up block infobar Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc b/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
index b057d7d4837a2ed514cfae470ce7e6ad2ce5a038..63e98d3d22579f4e3354dfe4e95b212233a2c1ae 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
@@ -140,8 +140,8 @@ bool ShouldOpenAll(gfx::NativeWindow parent,
return ShowQuestionMessageBox(
parent, l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
- l10n_util::GetStringFUTF16(IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL,
- base::IntToString16(child_count))) ==
+ l10n_util::GetPluralStringFUTF16(IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL,
+ child_count)) ==
MESSAGE_BOX_RESULT_YES;
}
#endif
@@ -231,8 +231,9 @@ bool ConfirmDeleteBookmarkNode(const BookmarkNode* node,
DCHECK(node && node->is_folder() && !node->empty());
return ShowQuestionMessageBox(
window, l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
- l10n_util::GetStringFUTF16Int(IDS_BOOKMARK_EDITOR_CONFIRM_DELETE,
- ChildURLCountTotal(node))) ==
+ l10n_util::GetPluralStringFUTF16(
+ IDS_BOOKMARK_EDITOR_CONFIRM_DELETE,
+ ChildURLCountTotal(node))) ==
MESSAGE_BOX_RESULT_YES;
}

Powered by Google App Engine
This is Rietveld 408576698