Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4661)

Unified Diff: chrome/browser/media/desktop_media_list_ash.cc

Issue 2002783002: Use plural formats and native digits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: plural: use "=1" instead of "one" for pop-up block infobar Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/media/native_desktop_media_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/desktop_media_list_ash.cc
diff --git a/chrome/browser/media/desktop_media_list_ash.cc b/chrome/browser/media/desktop_media_list_ash.cc
index 5645b4f0eb937fd44fcb17d708b8e585fdb9f782..b5a9898fe0b9b8fb25407e0e116cfe7df5013139 100644
--- a/chrome/browser/media/desktop_media_list_ash.cc
+++ b/chrome/browser/media/desktop_media_list_ash.cc
@@ -82,7 +82,12 @@ void DesktopMediaListAsh::EnumerateSources(
if (screen_source.name.empty()) {
if (root_windows.size() > 1) {
- screen_source.name = l10n_util::GetStringFUTF16Int(
+ // 'Screen' in 'Screen 1, Screen 2, etc ' might be inflected in some
+ // languages depending on the number although rather unlikely. To be
+ // safe, use the plural format.
+ // TODO(jshin): Revert to GetStringFUTF16Int (with native digits)
+ // if none of UI languages inflects 'Screen' in this context.
+ screen_source.name = l10n_util::GetPluralStringFUTF16(
IDS_DESKTOP_MEDIA_PICKER_MULTIPLE_SCREEN_NAME,
static_cast<int>(i + 1));
} else {
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/media/native_desktop_media_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698