chrome/browser/resources/print_preview/settings/dpi_settings.js - Issue 2002783002: Use plural formats and native digits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/dpi_settings.js

Issue 2002783002: Use plural formats and native digits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment changes: l10n_util Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/print_preview/settings/dpi_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/dpi_settings.js b/chrome/browser/resources/print_preview/settings/dpi_settings.js

index a06dc9e9df4e838708dc7965998b6d3e1c079581..8adef40e7189ef65fa27f57608c516366aca415e 100644

--- a/chrome/browser/resources/print_preview/settings/dpi_settings.js

+++ b/chrome/browser/resources/print_preview/settings/dpi_settings.js

@@ -24,8 +24,11 @@ cr.define('print_preview', function() {

var hDpi = option.horizontal_dpi || 0;

var vDpi = option.vertical_dpi || 0;

if (hDpi > 0 && vDpi > 0 && hDpi != vDpi)

Dan Beam 2016/06/01 21:33:24 needs { curlies } now

jungshik at Google 2016/06/01 23:20:22 Done.

- return loadTimeData.getStringF('nonIsotropicDpiItemLabel', hDpi, vDpi);

- return loadTimeData.getStringF('dpiItemLabel', hDpi || vDpi);

+ return loadTimeData.getStringF('nonIsotropicDpiItemLabel',

+ hDpi.toLocaleString(),

+ vDpi.toLocaleString());

+ return loadTimeData.getStringF('dpiItemLabel',

+ (hDpi || vDpi).toLocaleString());

}

};