Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 cr.define('print_preview', function() { | 5 cr.define('print_preview', function() { |
| 6 'use strict'; | 6 'use strict'; |
| 7 | 7 |
| 8 /** | 8 /** |
| 9 * Encapsulates all settings and logic related to the DPI selection UI. | 9 * Encapsulates all settings and logic related to the DPI selection UI. |
| 10 * @param {!print_preview.ticket_items.Dpi} ticketItem Used to read and write | 10 * @param {!print_preview.ticket_items.Dpi} ticketItem Used to read and write |
| 11 * the DPI ticket item. | 11 * the DPI ticket item. |
| 12 * @constructor | 12 * @constructor |
| 13 * @extends {print_preview.SettingsSectionSelect} | 13 * @extends {print_preview.SettingsSectionSelect} |
| 14 */ | 14 */ |
| 15 function DpiSettings(ticketItem) { | 15 function DpiSettings(ticketItem) { |
| 16 print_preview.SettingsSectionSelect.call(this, ticketItem); | 16 print_preview.SettingsSectionSelect.call(this, ticketItem); |
| 17 }; | 17 }; |
| 18 | 18 |
| 19 DpiSettings.prototype = { | 19 DpiSettings.prototype = { |
| 20 __proto__: print_preview.SettingsSectionSelect.prototype, | 20 __proto__: print_preview.SettingsSectionSelect.prototype, |
| 21 | 21 |
| 22 /** @override */ | 22 /** @override */ |
| 23 getDefaultDisplayName_: function(option) { | 23 getDefaultDisplayName_: function(option) { |
| 24 var hDpi = option.horizontal_dpi || 0; | 24 var hDpi = option.horizontal_dpi || 0; |
| 25 var vDpi = option.vertical_dpi || 0; | 25 var vDpi = option.vertical_dpi || 0; |
| 26 if (hDpi > 0 && vDpi > 0 && hDpi != vDpi) | 26 if (hDpi > 0 && vDpi > 0 && hDpi != vDpi) |
|
Dan Beam
2016/06/01 21:33:24
needs { curlies } now
jungshik at Google
2016/06/01 23:20:22
Done.
| |
| 27 return loadTimeData.getStringF('nonIsotropicDpiItemLabel', hDpi, vDpi); | 27 return loadTimeData.getStringF('nonIsotropicDpiItemLabel', |
| 28 return loadTimeData.getStringF('dpiItemLabel', hDpi || vDpi); | 28 hDpi.toLocaleString(), |
| 29 vDpi.toLocaleString()); | |
| 30 return loadTimeData.getStringF('dpiItemLabel', | |
| 31 (hDpi || vDpi).toLocaleString()); | |
| 29 } | 32 } |
| 30 }; | 33 }; |
| 31 | 34 |
| 32 // Export | 35 // Export |
| 33 return { | 36 return { |
| 34 DpiSettings: DpiSettings | 37 DpiSettings: DpiSettings |
| 35 }; | 38 }; |
| 36 }); | 39 }); |
| OLD | NEW |