Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2002773002: Add overscanCalibration methods to system_display.idl (Closed)

Created:
4 years, 7 months ago by stevenjb
Modified:
4 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add overscanCalibration methods to system_display.idl BUG=547080 For c/b/extensions and idl: TBR=asargent@chromium.org Committed: https://crrev.com/12f6770567a7345e8f820c05e7005a512b1d6230 Cr-Commit-Position: refs/heads/master@{#395793}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Fix non-chromeos + tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -29 lines) Patch
M chrome/browser/chromeos/display/display_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.h View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 6 chunks +69 lines, -17 lines 0 comments Download
M extensions/browser/api/system_display/display_info_provider.h View 2 chunks +10 lines, -0 lines 0 comments Download
M extensions/browser/api/system_display/display_info_provider.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.h View 1 2 4 chunks +57 lines, -3 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.cc View 1 2 4 chunks +96 lines, -5 lines 0 comments Download
M extensions/browser/api/system_display/system_display_apitest.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/api/system_display.idl View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/closure_compiler/externs/system_display.js View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/closure_compiler/interfaces/system_display_interface.js View 1 chunk +36 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
stevenjb
4 years, 7 months ago (2016-05-21 00:04:29 UTC) #2
oshima
lgtm with a nit https://codereview.chromium.org/2002773002/diff/1/extensions/common/api/system_display.idl File extensions/common/api/system_display.idl (right): https://codereview.chromium.org/2002773002/diff/1/extensions/common/api/system_display.idl#newcode203 extensions/common/api/system_display.idl:203: // Complete overscan adjustments for ...
4 years, 7 months ago (2016-05-21 01:16:36 UTC) #3
xiyuan
lgtm
4 years, 7 months ago (2016-05-24 17:18:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002773002/1
4 years, 7 months ago (2016-05-24 17:34:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/10568) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-24 17:37:01 UTC) #8
stevenjb
+isherman@ for histograms OWNERS
4 years, 7 months ago (2016-05-24 18:50:55 UTC) #10
stevenjb
+mpearson@, +rkaplow@ for histograms owner
4 years, 7 months ago (2016-05-24 20:22:27 UTC) #12
Mark P
histograms.xml lgtm
4 years, 7 months ago (2016-05-24 21:11:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002773002/20001
4 years, 7 months ago (2016-05-24 21:19:47 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/189098)
4 years, 7 months ago (2016-05-24 21:29:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002773002/40001
4 years, 7 months ago (2016-05-25 00:03:39 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-25 03:28:19 UTC) #25
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/12f6770567a7345e8f820c05e7005a512b1d6230 Cr-Commit-Position: refs/heads/master@{#395793}
4 years, 7 months ago (2016-05-25 03:30:07 UTC) #27
asargent_no_longer_on_chrome
4 years, 7 months ago (2016-05-25 23:17:38 UTC) #28
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698