Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 2002763003: webRequest: reliably determine tabId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webRequest-testing-unload
Patch Set: Last nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/web_request/web_request_event_details.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/web_request/web_request_api.cc
diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc
index e60c50c3a3f787ddc1b20802c3746eb90d0ad2a4..29eefe5ce08601c192aef135fcd45aa6eaf11c9a 100644
--- a/extensions/browser/api/web_request/web_request_api.cc
+++ b/extensions/browser/api/web_request/web_request_api.cc
@@ -243,7 +243,7 @@ void SendOnMessageEventOnUI(
return;
std::unique_ptr<base::ListValue> event_args(new base::ListValue);
- event_details->DetermineFrameIdOnUI();
+ event_details->DetermineFrameDataOnUI();
event_args->Append(event_details->GetAndClearDict());
EventRouter* event_router = EventRouter::Get(browser_context);
@@ -601,17 +601,6 @@ ExtensionWebRequestEventRouter::CreateEventDetails(
std::unique_ptr<WebRequestEventDetails> event_details(
new WebRequestEventDetails(request, extra_info_spec));
- int render_frame_id = -1;
- int render_process_id = -1;
- int tab_id = -1;
- ExtensionApiFrameIdMap::FrameData frame_data;
- if (content::ResourceRequestInfo::GetRenderFrameForRequest(
- request, &render_process_id, &render_frame_id) &&
- ExtensionApiFrameIdMap::Get()->GetCachedFrameDataOnIO(
- render_process_id, render_frame_id, &frame_data)) {
- tab_id = frame_data.tab_id;
- }
- event_details->SetInteger(keys::kTabIdKey, tab_id);
return event_details;
}
@@ -1032,7 +1021,7 @@ bool ExtensionWebRequestEventRouter::DispatchEvent(
}
}
- event_details.release()->DetermineFrameIdOnIO(base::Bind(
+ event_details.release()->DetermineFrameDataOnIO(base::Bind(
&ExtensionWebRequestEventRouter::DispatchEventToListeners, AsWeakPtr(),
browser_context, base::Passed(&listeners_to_dispatch)));
« no previous file with comments | « no previous file | extensions/browser/api/web_request/web_request_event_details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698