Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2002723002: Remove unnecessary check (Closed)

Created:
4 years, 7 months ago by scroggo_chromium
Modified:
4 years, 7 months ago
Reviewers:
msarett, scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@kGray
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unnecessary check Follow-on from crrev.com/1996993003 No need to check the alpha type. If the color type is gray, the source alpha type will be opaque. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002723002 Committed: https://skia.googlesource.com/skia/+/1a3619236b5363821b58698a8731168803bd29fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M dm/DMSrcSink.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
scroggo
4 years, 7 months ago (2016-05-20 21:12:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002723002/1
4 years, 7 months ago (2016-05-20 21:12:41 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-20 21:12:42 UTC) #6
reed1
lgtm
4 years, 7 months ago (2016-05-20 21:13:38 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 21:27:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1a3619236b5363821b58698a8731168803bd29fe

Powered by Google App Engine
This is Rietveld 408576698