Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2002683002: Remove unused forward decls from render_frame.h (Closed)

Created:
4 years, 7 months ago by dglazkov
Modified:
4 years, 6 months ago
Reviewers:
esprehn, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused forward decls from render_frame.h RenderFrame no longer knows about WebElement or WebNode, yay! R=esprehn BUG= Committed: https://crrev.com/861acbc298c907dc596ca32eedab73d06638fecb Cr-Commit-Position: refs/heads/master@{#398114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/public/renderer/render_frame.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002683002/1
4 years, 7 months ago (2016-05-20 18:03:13 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 18:51:02 UTC) #4
esprehn
lgtm
4 years, 7 months ago (2016-05-20 19:41:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002683002/1
4 years, 7 months ago (2016-05-20 19:42:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/187565)
4 years, 7 months ago (2016-05-20 19:49:57 UTC) #9
dglazkov
+jam, when you get back, no rush.
4 years, 7 months ago (2016-05-20 19:51:33 UTC) #11
jam
lgtm
4 years, 6 months ago (2016-06-06 18:06:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002683002/1
4 years, 6 months ago (2016-06-06 18:34:59 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 20:37:52 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:40:24 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/861acbc298c907dc596ca32eedab73d06638fecb
Cr-Commit-Position: refs/heads/master@{#398114}

Powered by Google App Engine
This is Rietveld 408576698