Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc

Issue 2002673003: i18n of several browser messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc b/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
index b057d7d4837a2ed514cfae470ce7e6ad2ce5a038..101ef3e0654772c46b795ff48acef8719ccb278b 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
@@ -4,9 +4,9 @@
#include "chrome/browser/ui/bookmarks/bookmark_utils_desktop.h"
+#include "base/i18n/number_formatting.h"
#include "base/logging.h"
#include "base/macros.h"
-#include "base/strings/string_number_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/profiles/profile.h"
@@ -141,7 +141,7 @@ bool ShouldOpenAll(gfx::NativeWindow parent,
return ShowQuestionMessageBox(
parent, l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
l10n_util::GetStringFUTF16(IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL,
- base::IntToString16(child_count))) ==
+ base::FormatNumber(child_count))) ==
jungshik at Google 2016/05/20 23:58:03 This need to use a plural format (GetPluralStringF
Greg Levin 2016/05/26 14:03:13 Ok, reverted my change to this file in next patch.
MESSAGE_BOX_RESULT_YES;
}
#endif

Powered by Google App Engine
This is Rietveld 408576698