i18n of several browser messages

chrome/browser/ui/views/critical_notification_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/critical_notification_bubble_view.h"
 
-#include "base/strings/string_number_conversions.h"
+#include "base/i18n/number_formatting.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/upgrade_detector.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/locale_settings.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/user_metrics.h"
@@ skipping 61 matching lines @@
   // an onbeforeunload handler, leaving the bubble up when the browser should
   // have restarted (giving the user another chance).
   GetBubbleFrameView()->UpdateWindowTitle();
 }
 
 base::string16 CriticalNotificationBubbleView::GetWindowTitle() const {
   int seconds = GetRemainingTime();
   return seconds > 0 ? l10n_util::GetStringFUTF16(
                            IDS_CRITICAL_NOTIFICATION_HEADLINE,
                            l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
-                           base::IntToString16(seconds))
+                           base::FormatNumber(seconds))

[jungshik at Google, 2016/05/20 23:58:03]

This one is also caught in my search for <ex>[0-9]+</ex> and I was getting there
(but not yet). Why don't you just go ahead with the following?


This also needs to use plural format or a measure format (with seconds). 

<ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> will restart in <ph
name="SECONDS">$2<ex>10</ex></ph> seconds.

In grd, the message spec has to be :

{1, plural, 
  =1{<ph name="PRODUCT_NAME">{0}<ex>Google Chrome</ex></ph> will restart in a
second.}
  other{<ph name="PRO...</ph> will restart in # seconds.}
}

Note that there are two input values to pass (one is string and the other is
integer). So, GetPluralStringFUTF16 helper cannot be used. You have to use

MessageFormatter::FormatWithNumberedArgs(GetStringUTF16(<msg id>), 
GetStringUTF16(IDS_PRODUCT_NAME), seconds); 

[Greg Levin, 2016/05/26 14:03:14]

Done.

                      : l10n_util::GetStringFUTF16(
                            IDS_CRITICAL_NOTIFICATION_HEADLINE_ALTERNATE,
                            l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
 }
 
 gfx::ImageSkia CriticalNotificationBubbleView::GetWindowIcon() {
   return *ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
       IDR_UPDATE_MENU_SEVERITY_HIGH);
 }
 
@@ skipping 55 matching lines @@
 void CriticalNotificationBubbleView::GetAccessibleState(
     ui::AXViewState* state) {
   state->role = ui::AX_ROLE_ALERT;
 }
 
 void CriticalNotificationBubbleView::ViewHierarchyChanged(
     const ViewHierarchyChangedDetails& details) {
   if (details.is_add && details.child == this)
     NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
 }