Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2002673002: Use std::map for CFX_GEFont::m_FontMapper (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use std::map for CFX_GEFont::m_FontMapper Committed: https://pdfium.googlesource.com/pdfium/+/bc34be4dbb7b11252a48110f89c46ccb01929d64

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M xfa/fgas/font/fgas_gefont.h View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 5 chunks +14 lines, -20 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-20 17:35:53 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2002673002/diff/1/xfa/fgas/font/fgas_gefont.cpp File xfa/fgas/font/fgas_gefont.cpp (right): https://codereview.chromium.org/2002673002/diff/1/xfa/fgas/font/fgas_gefont.cpp#newcode157 xfa/fgas/font/fgas_gefont.cpp:157: delete m_pFontEncoding; BTW, lots of unique_ptr candidates.
4 years, 7 months ago (2016-05-20 20:42:22 UTC) #3
Tom Sepez
https://codereview.chromium.org/2002673002/diff/1/xfa/fgas/font/fgas_gefont.cpp File xfa/fgas/font/fgas_gefont.cpp (right): https://codereview.chromium.org/2002673002/diff/1/xfa/fgas/font/fgas_gefont.cpp#newcode157 xfa/fgas/font/fgas_gefont.cpp:157: delete m_pFontEncoding; On 2016/05/20 20:42:21, Lei Zhang wrote: > ...
4 years, 7 months ago (2016-05-20 21:32:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002673002/1
4 years, 7 months ago (2016-05-20 21:32:24 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 21:32:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bc34be4dbb7b11252a48110f89c46ccb0192...

Powered by Google App Engine
This is Rietveld 408576698