Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2002663002: gyp (third_party) warning changes for ccache (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, csmartdalton
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

gyp (third_party) warning changes for ccache Also fix a broken unit test in MatrixTest.cpp. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002663002 Committed: https://skia.googlesource.com/skia/+/e76ca8b9c25672be79b670514a7fe0bceadd35e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M gyp/lua.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
M gyp/microhttpd.gyp View 1 chunk +9 lines, -0 lines 0 comments Download
M gyp/zlib.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/MatrixTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002663002/1
4 years, 7 months ago (2016-05-20 17:18:08 UTC) #4
hal.canary
please take a look
4 years, 7 months ago (2016-05-20 17:22:07 UTC) #8
bsalomon
lgtm
4 years, 7 months ago (2016-05-20 17:25:16 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 17:33:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002663002/1
4 years, 7 months ago (2016-05-20 17:35:56 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 17:36:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e76ca8b9c25672be79b670514a7fe0bceadd35e6

Powered by Google App Engine
This is Rietveld 408576698