Add separate UMA histograms for the account chooser with 1/many accounts.

Add separate UMA histograms for the account chooser with 1/many accounts.

BUG=612501
Committed: https://crrev.com/d7185e01e17811c2e0beafdb88bcc0ad0d286e57
Cr-Commit-Position: refs/heads/master@{#395556}

[vasilii, 2016-05-20 16:20:27]

vasilii@chromium.org changed reviewers:
+ isherman@chromium.org

[vasilii, 2016-05-20 16:20:28]

Hi Ilya,

please review the whole CL.

[Ilya Sherman, 2016-05-20 21:59:23]

https://chromiumcodereview.appspot.com/2002643002/diff/1/chrome/browser/ui/pa...
File chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
(right):

https://chromiumcodereview.appspot.com/2002643002/diff/1/chrome/browser/ui/pa...
chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc:169:
controller().ShowAccountChooser(&prompt, std::move(locals),
Hmm, why did you need to make this change?

https://chromiumcodereview.appspot.com/2002643002/diff/1/components/password_...
File components/password_manager/core/browser/password_manager_metrics_util.h
(right):

https://chromiumcodereview.appspot.com/2002643002/diff/1/components/password_...
components/password_manager/core/browser/password_manager_metrics_util.h:177:
bool one_account);
nit: Please define a pair of enumerated constants to pass into this method,
rather than passing a bool, for the sake of clearer callsites.  Or, better yet,
please just define two separate methods, one for each possible case.

https://chromiumcodereview.appspot.com/2002643002/diff/1/tools/metrics/histog...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/2002643002/diff/1/tools/metrics/histog...
tools/metrics/histograms/histograms.xml:36311: +    The dismissal reason of the
account chooser with few accounts.
nit: s/few/multiple

[vasilii-Google, 2016-05-23 11:03:45]

vasilii@google.com changed reviewers:
+ vasilii@google.com

[vasilii-Google, 2016-05-23 11:03:46]

https://chromiumcodereview.appspot.com/2002643002/diff/1/chrome/browser/ui/pa...
File chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
(right):

https://chromiumcodereview.appspot.com/2002643002/diff/1/chrome/browser/ui/pa...
chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc:169:
controller().ShowAccountChooser(&prompt, std::move(locals),
On 2016/05/20 21:59:23, Ilya Sherman wrote:
> Hmm, why did you need to make this change?

I want the account chooser to have 1 account. 0 accounts is impossible.

https://chromiumcodereview.appspot.com/2002643002/diff/1/components/password_...
File components/password_manager/core/browser/password_manager_metrics_util.h
(right):

https://chromiumcodereview.appspot.com/2002643002/diff/1/components/password_...
components/password_manager/core/browser/password_manager_metrics_util.h:177:
bool one_account);
On 2016/05/20 21:59:23, Ilya Sherman wrote:
> nit: Please define a pair of enumerated constants to pass into this method,
> rather than passing a bool, for the sake of clearer callsites.  Or, better
yet,
> please just define two separate methods, one for each possible case.

Done.

https://chromiumcodereview.appspot.com/2002643002/diff/1/tools/metrics/histog...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/2002643002/diff/1/tools/metrics/histog...
tools/metrics/histograms/histograms.xml:36311: +    The dismissal reason of the
account chooser with few accounts.
On 2016/05/20 21:59:23, Ilya Sherman wrote:
> nit: s/few/multiple

Done.

[vasilii, 2016-05-23 11:04:55]

Description was changed from

==========
Add separate UMA histograms for the account chooser with 1/many accounts.

BUG=612501
==========

to

==========
Add separate UMA histograms for the account chooser with 1/many accounts.

BUG=612501
==========

[vasilii, 2016-05-23 11:04:55]

vasilii@chromium.org changed reviewers:
- vasilii@google.com

[Ilya Sherman, 2016-05-23 18:34:03]

LGTM

[vasilii, 2016-05-24 08:31:31]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2016-05-24 08:32:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002643002/20001

[commit-bot: I haz the power, 2016-05-24 09:28:55]

Description was changed from

==========
Add separate UMA histograms for the account chooser with 1/many accounts.

BUG=612501
==========

to

==========
Add separate UMA histograms for the account chooser with 1/many accounts.

BUG=612501
==========

[commit-bot: I haz the power, 2016-05-24 09:28:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-24 09:31:14]

Description was changed from

==========
Add separate UMA histograms for the account chooser with 1/many accounts.

BUG=612501
==========

to

==========
Add separate UMA histograms for the account chooser with 1/many accounts.

BUG=612501

Committed: https://crrev.com/d7185e01e17811c2e0beafdb88bcc0ad0d286e57
Cr-Commit-Position: refs/heads/master@{#395556}
==========

[commit-bot: I haz the power, 2016-05-24 09:31:16]

Patchset 2 (id:??) landed as
https://crrev.com/d7185e01e17811c2e0beafdb88bcc0ad0d286e57
Cr-Commit-Position: refs/heads/master@{#395556}