LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout.html - Issue 200263003: [CSS Grid Layout] the "grid-template-areas" is not identified as computable property.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout.html

Issue 200263003: [CSS Grid Layout] the "grid-template-areas" is not identified as computable property. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied suggested changes. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <script>
	apavlov 2014/03/26 14:40:59 I've seen a few cases where reviewers insisted on I've seen a few cases where reviewers insisted on having a doctype (e.g. <!DOCTYPE html>), since the quirks mode can result in unexpected behavior... quirks. Nearly all files in this directory have their doctypes set (and the <html> and <head> tags will not harm in this case, too). jfernandez 2014/03/28 00:28:38 Done. Show quoted text On 2014/03/26 14:40:59, apavlov wrote: > I've seen a few cases where reviewers insisted on having a doctype (e.g. > <!DOCTYPE html>), since the quirks mode can result in unexpected behavior... > quirks. Nearly all files in this directory have their doctypes set (and the > <html> and <head> tags will not harm in this case, too). Done.
	2 var propertiesToTest = {

	3 "grid-auto-columns": true,

	4 "grid-auto-flow": true,

	5 "grid-auto-rows": true,

	6 "grid-area": true,

	7 "grid-column": true,

	8 "grid-column-end": true,

	9 "grid-column-start": true,

	10 "grid-template-columns": true,

	11 "grid-template-rows": true,

	12 "grid-row": true,

	13 "grid-row-end": true,

	14 "grid-row-start": true,

	15 "grid-template-areas": true,

	16 };

	17

	18 function test()

	19 {

	20 if (window.testRunner)

	21 testRunner.dumpAsText();

	22 var style = document.defaultView.getComputedStyle(document.body, "");

	23 var text = "";

	24 for (var i = 0; i != style.length; ++i) {
	apavlov 2014/03/26 14:40:59 You could make propertiesToTest an array and itera You could make propertiesToTest an array and iterate it instead - that would be a tad faster ;) (a dozen properties rather than the entire style declaration) and avoid having the style.item() call. jfernandez 2014/03/28 00:28:38 This could be an option, but one of the purposes o Show quoted text On 2014/03/26 14:40:59, apavlov wrote: > You could make propertiesToTest an array and iterate it instead - that would be > a tad faster ;) (a dozen properties rather than the entire style declaration) > and avoid having the style.item() call. This could be an option, but one of the purposes of the tests is also to identify properties wrongly assigned to the staticComputableProperties array while still being computable properties. The shorthands are an example of those. I tried to implement the test like you suggested, but I couldn't find a way to determine that the "grid-area" shorthand, for example, is not present in the CSSStyeDeclaration associative array. So, iterating over all the 'style' elements was the only way,
	25 var name = style.item(i);

	26 if (!propertiesToTest[name])

	27 continue;

	28 text += name + ": " + style.getPropertyValue(name) + ";\n";

	29 }

	30 document.getElementById("exposed").textContent = text;

	31 }

	32 </script>

	33 <body onload="test()">

	34 <p>CSS Grid Layout Attributes that are exposed in the CSS computed style object: </p>

	35 <p id="exposed" style="white-space: pre"></p>

	36 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout-expected.txt » ('j') | no next file with comments »