Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 200263002: Revert of [webcrypto] JWK: Updated import(ext, key_ops) and added export of symmetric keys (Closed)

Created:
6 years, 9 months ago by Finnur
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@wcAesKw_nss1
Visibility:
Public.

Description

Revert of [webcrypto] JWK: Updated import(ext, key_ops) and added export of symmetric keys (https://codereview.chromium.org/184043021/) Reason for revert: SharedCryptoTest.ImportExportJwkSymmetricKey test failing. http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/57322 Original issue's description: > [webcrypto] JWK: Updated import(ext, key_ops) and added export of symmetric keys > > See https://www.w3.org/Bugs/Public/show_bug.cgi?id=23796 > > BUG=245025 > TEST=content_unittests --gtest_filter="SharedCryptoTest*" > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256399 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257078 TBR=eroman@chromium.org,rsleevi@chromium.org,bryaneyler@google.com,padolph@netflix.com NOTREECHECKS=true NOTRY=true BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -802 lines) Patch
M content/child/webcrypto/jwk.cc View 16 chunks +62 lines, -280 lines 0 comments Download
M content/child/webcrypto/shared_crypto.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 25 chunks +41 lines, -395 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.h View 4 chunks +5 lines, -33 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 4 chunks +6 lines, -91 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
Created Revert of [webcrypto] JWK: Updated import(ext, key_ops) and added export of symmetric keys
6 years, 9 months ago (2014-03-14 12:31:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/200263002/1
6 years, 9 months ago (2014-03-14 12:32:02 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 12:32:47 UTC) #3
Message was sent while issue was closed.
Change committed as 257087

Powered by Google App Engine
This is Rietveld 408576698